Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18586 )
Change subject: IMPALA-11314: Test PyPI package with system python ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/18586/10/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18586/10/shell/CMakeLists.txt@42 PS10, Line 42: "${CMAKE_SOURCE_DIR}/shell/build/dist/impala_shell-install-test.tar.gz" > I can switch to a custom command for clarity. It'll still rebuild every tim When I do this, I also have to add a separate custom target to synchronize so I only build one instance of the test package. Custom commands seem to be rolled into the test targets that depend on them, and Make doesn't see them as a shared dependency between two targets. -- To view, visit http://gerrit.cloudera.org:8080/18586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I384ea6a7dab51945828cca629860400a23fa0c05 Gerrit-Change-Number: 18586 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Jun 2022 17:38:58 +0000 Gerrit-HasComments: Yes
