Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18636
to look at the new patch set (#3).
Change subject: IMPALA-11369: Separate thrift compiler for different component
......................................................................
IMPALA-11369: Separate thrift compiler for different component
Impala used to have one thrift compiler version to compile C++, Java,
and Python code.
Most Thrift serialization/deserialization between minor versions are
compatible with each other. So it is possible to have different thrift
compiler versions for different target codes. It is beneficial to do so
because it will allow Impala to upgrade separate components
independently.
This patch implements the infrastructure change required to do so. It
replace most of the 'THRIFT_*' environment variable and CMake variable
with 'THRFIT_CPP_*', 'THRFIT_JAVA_*', and 'THRFIT_PY_*' to compile C++,
Java, and Python code accordingly. All three still refer to the same
thrift version (thrift-0.11.0-p5).
Testing:
- Build Impala and pass core tests.
Change-Id: I56479dc69b79024d1a4d09211bbe88a61fa0c6a4
---
M CMakeLists.txt
M README-build.md
M be/CMakeLists.txt
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/impala-shell.sh
M bin/set-pythonpath.sh
D cmake_modules/FindThrift.cmake
A cmake_modules/FindThriftCpp.cmake
A cmake_modules/FindThriftJava.cmake
A cmake_modules/FindThriftPython.cmake
M common/thrift/CMakeLists.txt
M java/pom.xml
M shell/make_shell_tarball.sh
M shell/packaging/make_python_package.sh
15 files changed, 286 insertions(+), 134 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/18636/3
--
To view, visit http://gerrit.cloudera.org:8080/18636
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I56479dc69b79024d1a4d09211bbe88a61fa0c6a4
Gerrit-Change-Number: 18636
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
