Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )
Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read ...................................................................... Patch Set 5: (2 comments) Thanks for working on this fix. http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/hdfs-orc-scanner.cc@406 PS5, Line 406: (!scan_node_->hdfs_table()->IsIcebergTable() && : !scan_node_->hdfs_table()->IsTableFullAcid() This allows empty children for all non-iceberg non-full acid tables. Instead of this, can we only allow empty children when there are missing fields? Or only if all selected fields are missing? http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/orc-column-readers.cc@534 PS5, Line 534: // We allow empty 'children_' for original files, because we might select the : // synthetic 'rowid' field which is not present in original files. : // We also allow empty 'children_' when we need to validate row batches of a zero slot : // scan. In that case 'children_' is empty and only 'row_validator_' owns an ORC : // vector batch (the write id batch). Can we move this comment to the declaration of 'valid_empty_children_'? -- To view, visit http://gerrit.cloudera.org:8080/18652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023 Gerrit-Change-Number: 18652 Gerrit-PatchSet: 5 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 22 Jun 2022 09:22:57 +0000 Gerrit-HasComments: Yes
