Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )
Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18652/5/be/src/exec/hdfs-orc-scanner.cc@406 PS5, Line 406: (!scan_node_->hdfs_table()->IsIcebergTable() && : !scan_node_->hdfs_table()->IsTableFullAcid() > This allows empty children for all non-iceberg non-full acid tables. +1 on this. Maybe we can move this field into the OrcColumnReaders. In the readers, we match the table schema with the file schema and check missing fields there. -- To view, visit http://gerrit.cloudera.org:8080/18652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023 Gerrit-Change-Number: 18652 Gerrit-PatchSet: 5 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Thu, 23 Jun 2022 02:50:20 +0000 Gerrit-HasComments: Yes
