Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18653 )

Change subject: IMPALA-11389: Include Python 3 eggs in tarball
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18653/6/tests/shell/util.py
File tests/shell/util.py:

http://gerrit.cloudera.org:8080/#/c/18653/6/tests/shell/util.py@357
PS6, Line 357:     'dev3': ['env', 'IMPALA_PYTHON_EXECUTABLE=python3', 
impala_shell_executable],
> This dimension failed on TestImpalaShell.test_utf8_decoding_error_handling.
I'm pretty sure this fails because the fastbinary.so in thrift is compiled for 
Python 2. To make this work, we probably need separate thrift builds for Python 
2 and Python 3.



--
To view, visit http://gerrit.cloudera.org:8080/18653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444
Gerrit-Change-Number: 18653
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Thu, 23 Jun 2022 19:03:57 +0000
Gerrit-HasComments: Yes

Reply via email to