Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18653 )
Change subject: IMPALA-11389: Include Python 3 eggs in tarball ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/18653/10/shell/impala-shell File shell/impala-shell: http://gerrit.cloudera.org:8080/#/c/18653/10/shell/impala-shell@50 PS10, Line 50: if ! which "${PYTHON_EXE}" > /dev/null; then > Nit: There is an argument that 'which' should be avoided for detecting prog Ack -- To view, visit http://gerrit.cloudera.org:8080/18653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94f86de9e2a6303151c2f0e6454b5f629cbc9444 Gerrit-Change-Number: 18653 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 14 Jul 2022 16:11:22 +0000 Gerrit-HasComments: Yes
