Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18616 )
Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18616/4/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/18616/4/be/src/runtime/io/data-cache.cc@398 PS4, Line 398: } > Nit: Let's pull the 8 constant out as a global constant with its own variab Done http://gerrit.cloudera.org:8080/#/c/18616/4/be/src/util/disk-info.cc File be/src/util/disk-info.cc: http://gerrit.cloudera.org:8080/#/c/18616/4/be/src/util/disk-info.cc@96 PS4, Line 96: Substitute("$0/block/$1", sys, dev_name), &found_device); > Nit: Some C++ string manipulations create copies and can be wasteful. This I'd like to think compiler optimizations would target this pattern, but those are just hopes and Substitute is easy enough. -- To view, visit http://gerrit.cloudera.org:8080/18616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60761faa2710f4795f1f3eaf66da866b5553f609 Gerrit-Change-Number: 18616 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 24 Jun 2022 18:23:52 +0000 Gerrit-HasComments: Yes
