Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18616 )
Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18616/4/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/18616/4/be/src/runtime/io/data-cache.cc@839 PS4, Line 839: } : if (FLAGS_data_cache_write_concurrency < 0) { : return Status(Substitute("Misconfigured --data_cache_write_concurrency: $0. " : "Must be at least 0; 0 uses a device-specific default.", : FLAGS_data_cache_write_concurrency)); > Was this intentional? I think I would prefer negative values to fail. (This is about removing it in the later patch set) -- To view, visit http://gerrit.cloudera.org:8080/18616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60761faa2710f4795f1f3eaf66da866b5553f609 Gerrit-Change-Number: 18616 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 24 Jun 2022 21:12:22 +0000 Gerrit-HasComments: Yes
