Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18671
Change subject: IMPALA-10927: Deflaky TestFetchAndSpooling.test_rows_sent_counters ...................................................................... IMPALA-10927: Deflaky TestFetchAndSpooling.test_rows_sent_counters IMPALA-8957 fixed the flakiness for test by adding a delay via DEBUG_ACTION BPRS_BEFORE_ADD_ROWS in BlockingPlanRootSink::Send(). BPRS_BEFORE_ADD_ROWS should be used for spool_query_results as false, BPRS_BEFORE_ADD_BATCH should be used for spool_query_results as true. Extended dimension is added for TestFetchAndSpooling with spool_query_results as true. Now the default value of pool_query_results is set as true so spool_query_results as false is not tested in the test case. Since the test uses BPRS_BEFORE_ADD_ROWS if spool_query_results is not specified as true, it makes DEBUG_ACTION BPRS_BEFORE_ADD_ROWS to be used for spool_query_results as true. This causes the test flaky since no delay in BufferedPlanRootSink::Send(). Another issue is that the test uses bool() to convert string to boolean value, but the function returns true for any non empty string. This patch changed the extended dimension setting for spool_query_results as false, and made the test to use the right DEBUG_ACTION for spool_query_results as true and false. Also reverted the previous fixing which disabled the test for S3 testing environment. Testing: - Ran the test more than 300 times on local machine. Change-Id: I790bbe1072357caf8ee11bb37644cf29dc8bea0f --- M tests/query_test/test_fetch.py 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/18671/1 -- To view, visit http://gerrit.cloudera.org:8080/18671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I790bbe1072357caf8ee11bb37644cf29dc8bea0f Gerrit-Change-Number: 18671 Gerrit-PatchSet: 1 Gerrit-Owner: Wenzhe Zhou <[email protected]>
