Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18671 )
Change subject: IMPALA-10927: Deflaky TestFetchAndSpooling.test_rows_sent_counters ...................................................................... IMPALA-10927: Deflaky TestFetchAndSpooling.test_rows_sent_counters IMPALA-8957 fixed the flakiness for test by adding a delay via DEBUG_ACTION BPRS_BEFORE_ADD_ROWS in BlockingPlanRootSink::Send(). test_rows_sent_counters uses DEBUG_ACTION BPRS_BEFORE_ADD_BATCH when spool_query_results is on, and uses BPRS_BEFORE_ADD_ROWS when spool_query_results is off with assumption that result spooling is disabled by default. IMPALA-9856 enabled result spooling by default. Following two issues were introduced for the test when result spooling was enabled by default. 1) spool_query_results as false is not covered in the test since extended dimension is added with spool_query_results as true. 2) Since the test uses BPRS_BEFORE_ADD_ROWS if spool_query_results is not specified as true, it makes DEBUG_ACTION BPRS_BEFORE_ADD_ROWS to be used for spool_query_results as true. This causes the test flaky since no delay to be added in BufferedPlanRootSink::Send(). There is another bug in the test. It uses bool() to convert string to boolean value, but the function returns true for any non empty string. This patch changed the extended dimension setting for spool_query_results as false, and made the test to use the right DEBUG_ACTION for spool_query_results as true and false. Also reverted the previous fixing which disabled the test for S3 testing environment. Testing: - Ran the test more than 10000 times without failure on Jenkins. Change-Id: I790bbe1072357caf8ee11bb37644cf29dc8bea0f --- M tests/query_test/test_fetch.py 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/18671/2 -- To view, visit http://gerrit.cloudera.org:8080/18671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I790bbe1072357caf8ee11bb37644cf29dc8bea0f Gerrit-Change-Number: 18671 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
