Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions ...................................................................... Patch Set 8: (6 comments) Found a couple of nits, otherwise the change looks great! http://gerrit.cloudera.org:8080/#/c/18641/8/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/18641/8/common/thrift/CatalogObjects.thrift@574 PS8, Line 574: TIcebergPartitionContent nit: maybe a better name would be TIcebergPartitionStats or TIcebergPartitionInfo http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@303 PS8, Line 303: getPartitionSpecs nit: now a better name would be getPartitionStats() or getPartitionInfo() http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@310 PS8, Line 310: Partition Name nit: I think it's rather 'Partition' than 'Partition Name'. http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java: http://gerrit.cloudera.org:8080/#/c/18641/8/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCtasTarget.java@264 PS8, Line 264: partitionContent_ nit: I think we could just return null here, no need for the member. http://gerrit.cloudera.org:8080/#/c/18641/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test: http://gerrit.cloudera.org:8080/#/c/18641/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test@45 PS8, Line 45: __HIVE_DEFAULT_PARTITION__ nit: Iceberg just uses null here (without quotes): https://github.com/apache/hive/blob/c4c73c0435b34b332f65af77244db89ced12b44f/iceberg/iceberg-handler/src/test/results/positive/query_iceberg_metadata_of_partitioned_table.q.out#L583 In the file paths we use __HIVE_DEFAULT_PARTITION__ because Iceberg doesn't really care about the paths and having a long and ugly value to mark the null partitions seemed reasonable. Also, this behavior worked out of the box without any additional code change. But here in SHOW PARTITIONS I think it's probably better to output null. http://gerrit.cloudera.org:8080/#/c/18641/8/tests/custom_cluster/test_iceberg.py File tests/custom_cluster/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18641/8/tests/custom_cluster/test_iceberg.py@26 PS8, Line 26: class TestIcebergCustomConfigs(CustomClusterTestSuite, ImpalaTestSuite): I'm not strongly against this, but there is no need to put these tests into a custom cluster test as the Jenkins verify job runs the e2e tests in various configurations, i.e. with and without local catalog mode. -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 8 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 30 Jun 2022 16:41:28 +0000 Gerrit-HasComments: Yes
