[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/18641/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@575 PS6, Line 575: Returns nit: Return http://gerrit.cloudera.org:8080/#/c/18641/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@576 PS6, Line 576: resulset nit: result set http://gerrit.cloudera.org:8080/#/c/18641/6/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@585 PS6, Line 585: new TreeMap<>(); Already ensured that the return value of this method is ordered by the 'partitionKey', whether the reorder of 'fieldNameToPartitionValue' in method 'org.apache.impala.catalog.FeIcebergTable.Utils#getPartitionSpecs' can be omitted? -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 6 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 24 Jun 2022 16:17:36 +0000 Gerrit-HasComments: Yes
