Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18708 )
Change subject: IMPALA-11419: Incremental build is broken ...................................................................... Patch Set 1: Code-Review+2 (2 comments) There's a suggestion for the commit message, otherwise the change LGTM. Feel free to carry +2 and submit after considering the edit change. Thanks a lot for catching this! http://gerrit.cloudera.org:8080/#/c/18708/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18708/1//COMMIT_MSG@21 PS1, Line 21: covers nit: suggest rephrasing this as "hide" instead of "cover": I'm afraid "cover" might be misunderstood here as "takes care of" instead of the intended meaning of hiding the real root cause. http://gerrit.cloudera.org:8080/#/c/18708/1//COMMIT_MSG@25 PS1, Line 25: cover nit: same here -- To view, visit http://gerrit.cloudera.org:8080/18708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb0e2007f3fa0cc721bd7b272956ce206ac65b0e Gerrit-Change-Number: 18708 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal (Cloudera) <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 11 Jul 2022 13:43:58 +0000 Gerrit-HasComments: Yes
