Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/18708 )
Change subject: IMPALA-11419: Incremental build is broken
......................................................................
IMPALA-11419: Incremental build is broken
IMPALA-11384 broke incremental builds because:
* added a custom target that always rewrites a few generated
header files
** The files are getting included directly/indirectly in most files,
so we always need to recompile a large part of the project
* Didn't remove ${THRIFT_FILE_WE}_constants.cpp/h dependency from
common/thrift/CMakeLists.txt
** These files are not generated anymore, so the build system always
reconstruct all the generated files (because *_constant.cpp/h is
always missing), and then builds every target that depend on them.
IMPALA-11415 fixes a sporadic error during data loading, but it only
hides the root cause, i.e. unnecessary recreation of thrift files.
This patch reverts IMPALA-11415 because:
* to make data-load more parallel
* to not hide similar issues in the future
Testing
* Tested locally that the thrift files are not getting regenerated
Change-Id: Ieb0e2007f3fa0cc721bd7b272956ce206ac65b0e
Reviewed-on: http://gerrit.cloudera.org:8080/18708
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
A bin/cmake_aux/add_override.sh
M common/thrift/CMakeLists.txt
M testdata/bin/create-load-data.sh
3 files changed, 40 insertions(+), 12 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18708
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb0e2007f3fa0cc721bd7b272956ce206ac65b0e
Gerrit-Change-Number: 18708
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
