Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18676 )

Change subject: WIP KUDU-2671 support adding a range with custom hash schema
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18676/6/fe/src/main/java/org/apache/impala/analysis/RangePartition.java
File fe/src/main/java/org/apache/impala/analysis/RangePartition.java:

http://gerrit.cloudera.org:8080/#/c/18676/6/fe/src/main/java/org/apache/impala/analysis/RangePartition.java@122
PS6, Line 122:   public static RangePartition createFromValues(List<Expr> 
values, List<KuduPartitionParam> hashSpec) {
line too long (103 > 90)


http://gerrit.cloudera.org:8080/#/c/18676/6/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java:

http://gerrit.cloudera.org:8080/#/c/18676/6/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@272
PS6, Line 272:         throw new ImpalaRuntimeException("Error accessing Kudu 
for table hash schema.", e);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/18676/6/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/18676/6/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@403
PS6, Line 403:       TRangePartition rangePartition, List<Pair<PartialRow, 
RangePartitionBound>> rangeBounds) {
line too long (96 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/18676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I981056e0827f4957580706d6e73742e4e6743c1c
Gerrit-Change-Number: 18676
Gerrit-PatchSet: 6
Gerrit-Owner: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 12 Jul 2022 02:44:20 +0000
Gerrit-HasComments: Yes

Reply via email to