Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18676 )
Change subject: WIP KUDU-2671 support adding a range with custom hash schema ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18676/5/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/18676/5/fe/src/main/cup/sql-parser.cup@1730 PS5, Line 1730: hash_partition_param_list:hashspec > As Kurt mentioned offline, this can't parse multiple hash partition params After trying several different approaches, it seems that cup can only statically determine which production to follow when there is a conflict. There is a way to influence precedence using %prec keyword which we use elsewhere in the syntax but that does not seem to help in this case. Decided to go with grammar similar to the original but with no commas. -- To view, visit http://gerrit.cloudera.org:8080/18676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I981056e0827f4957580706d6e73742e4e6743c1c Gerrit-Change-Number: 18676 Gerrit-PatchSet: 5 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 12 Jul 2022 02:51:10 +0000 Gerrit-HasComments: Yes
