Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18718 )
Change subject: IMPALA-11355: Add STRING overloads for hour/minute/second/millisecond ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18718/5/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/18718/5/be/src/exprs/expr-test.cc@6967 PS5, Line 6967: TestIsNull("minute('09-10-11')", TYPE_INT); > Should it be "hour('838:59:59')"? changed it to hour - note that it doesn't matter too much, as all these functions return NULL if any component of time is invalid >MySQL's hour function seems to accept string where the hour part is more than >23. Checked with Hive and it doesn't accept it. I think that not accepting it is the safest way. -- To view, visit http://gerrit.cloudera.org:8080/18718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cc1c851ee71ab4fcc58105c7e9931155a483679 Gerrit-Change-Number: 18718 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Jul 2022 14:06:18 +0000 Gerrit-HasComments: Yes
