Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18718 )
Change subject: IMPALA-11355: Add STRING overloads for hour/minute/second/millisecond ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18718/6/be/src/benchmarks/expr-benchmark.cc File be/src/benchmarks/expr-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/18718/6/be/src/benchmarks/expr-benchmark.cc@940 PS6, Line 940: /*benchmarks.push_back(&BenchmarkLiterals); why comments out? http://gerrit.cloudera.org:8080/#/c/18718/6/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18718/6/be/src/exprs/timestamp-functions-ir.cc@300 PS6, Line 300: nit: extra spaces -- To view, visit http://gerrit.cloudera.org:8080/18718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cc1c851ee71ab4fcc58105c7e9931155a483679 Gerrit-Change-Number: 18718 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Jul 2022 19:36:46 +0000 Gerrit-HasComments: Yes
