Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Looks good, thanks. http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java: http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java@62 PS1, Line 62: boolean persistLoader Is there any place after this change where 'persistLoader' is false? If not, we may consider removing it to simplify the class. http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java@79 PS1, Line 79: public void close() { Nit: Add @Override annotation because now it is part of the implementation of the AutoCloseable interface. -- To view, visit http://gerrit.cloudera.org:8080/18611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24 Gerrit-Change-Number: 18611 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 15 Jul 2022 12:24:57 +0000 Gerrit-HasComments: Yes
