Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18611 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java: http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java@62 PS1, Line 62: G.debug("Loading UDF > Is there any place after this change where 'persistLoader' is false? If not It was always true, I am not sure why did I keep it. http://gerrit.cloudera.org:8080/#/c/18611/1/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfLoader.java@79 PS1, Line 79: if (!(classLoader_ instanceof URLClassLoader)) { > Nit: Add @Override annotation because now it is part of the implementation Done http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java: http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java@32 PS1, Line 32: public GenericImportsNearbyClassesUdf() { > nit: private? removed this "member_" - I think that JVM will load UtilForUdfConstructor / UtilForUdfInitialize anyway. The JIT can optimize it, but this happens only later. https://stackoverflow.com/questions/14207401/java-how-will-jvm-optimise-the-call-to-a-void-and-empty-function http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java: http://gerrit.cloudera.org:8080/#/c/18611/1/java/test-hive-udfs/src/main/java/org/apache/impala/ImportsNearbyClassesUdf.java@30 PS1, Line 30: public ImportsNearbyClassesUdf() { > nit: private See answer in GenericImportsNearbyClassesUdf -- To view, visit http://gerrit.cloudera.org:8080/18611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24 Gerrit-Change-Number: 18611 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 18 Jul 2022 14:11:52 +0000 Gerrit-HasComments: Yes
