Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18743 )
Change subject: IMPALA-11268: Allow STORED BY and STORED AS as well ...................................................................... Patch Set 4: (3 comments) Thank you for working on this! The change looks good, added some minor comments. http://gerrit.cloudera.org:8080/#/c/18743/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18743/4//COMMIT_MSG@10 PS4, Line 10: namely Kudu and Iceberg at the moment. Could you add some explanation of intent here as well? About the ground work to support specifying file formats for storage engines. http://gerrit.cloudera.org:8080/#/c/18743/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/18743/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2318 PS4, Line 2318: + nit: in this file the plus signs are in the previous line http://gerrit.cloudera.org:8080/#/c/18743/4/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/18743/4/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2854 PS4, Line 2854: STORED TEXTFILE Could you add some negative tests as well, like this test. -- To view, visit http://gerrit.cloudera.org:8080/18743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib677bea8e582bbc01c5fb8c81df57eb60b0ed961 Gerrit-Change-Number: 18743 Gerrit-PatchSet: 4 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 22 Jul 2022 09:21:14 +0000 Gerrit-HasComments: Yes
