Gergely Fürnstáhl has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18743 )

Change subject: IMPALA-11268: Allow STORED BY and STORED AS as well
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18743/7/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/18743/7/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2316
PS7, Line 2316: STORED AS
> Did you mean to add also STORED AS examples here? Or examples with both STO
I just copied the Jira task title here but I agree it's a bit confusing in this 
context.

For the task it makes sense, as we introduce stored by iceberg while keeping 
stored as iceberg as well for backward compatibility



--
To view, visit http://gerrit.cloudera.org:8080/18743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib677bea8e582bbc01c5fb8c81df57eb60b0ed961
Gerrit-Change-Number: 18743
Gerrit-PatchSet: 7
Gerrit-Owner: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tamas Mate <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 25 Jul 2022 11:22:40 +0000
Gerrit-HasComments: Yes

Reply via email to