Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18779 )
Change subject: IMPALA-11345: Parquet Bloom filtering failure if column is added to the schema ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18779/1/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18779/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@1992 PS1, Line 1992: INFO I think WARNING is better since this might impact performance. http://gerrit.cloudera.org:8080/#/c/18779/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@2002 PS1, Line 2002: VLOG(google::INFO) << Substitute( Logging this (and the above one) for each stat conjunct is too verbose, especially for large queries that have many predicates. Can we try to reduce the logs? E.g. collect the slot descriptors and log them once at the end of this method. -- To view, visit http://gerrit.cloudera.org:8080/18779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief3e6b6358d3dff3abe5beeda752033a7e8e16a6 Gerrit-Change-Number: 18779 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 28 Jul 2022 03:58:06 +0000 Gerrit-HasComments: Yes
