Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18779 )
Change subject: IMPALA-11345: Parquet Bloom filtering failure if column is added to the schema ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18779/1/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18779/1/be/src/exec/parquet/hdfs-parquet-scanner.cc@1992 PS1, Line 1992: are > On the other hand, do we have a way to update those old parquet files too? I think we can only regenerate the files. http://gerrit.cloudera.org:8080/#/c/18779/2/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18779/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@2074 PS2, Line 2074: for the for the nit: duplicated "for the" http://gerrit.cloudera.org:8080/#/c/18779/2/be/src/exec/parquet/hdfs-parquet-scanner.cc@2090 PS2, Line 2090: unexpected_missing_fields I think this should be 'expected_missing_fields'. -- To view, visit http://gerrit.cloudera.org:8080/18779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief3e6b6358d3dff3abe5beeda752033a7e8e16a6 Gerrit-Change-Number: 18779 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 29 Jul 2022 01:24:45 +0000 Gerrit-HasComments: Yes
