Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 )
Change subject: IMPALA-6684: Fix untracked memory in KRPC ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18798/4/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/18798/4/be/src/runtime/krpc-data-stream-sender.cc@753 PS4, Line 753: // on some channel > I think it will make more sense to do this in Close() It works. http://gerrit.cloudera.org:8080/#/c/18798/5/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/18798/5/be/src/runtime/row-batch.h@422 PS5, Line 422: us Serialize(OutboundRowBatch* output_batch, LockingFreePool* perm_free_pool, : RuntimeProfile::SummaryStatsCounter* tuple_data_stats_counter, We can return counters as integer, then update the profile counter in the caller. This will make unit-test code row-batch-serialize-test.cc easier. Same comment for line #531. http://gerrit.cloudera.org:8080/#/c/18798/5/be/src/runtime/row-batch.h@577 PS5, Line 577: /// row batch). If the distinct_tuples argument is non-null, full deduplication is nit: extra line -- To view, visit http://gerrit.cloudera.org:8080/18798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba2b907ce4f275a7a1fb8cf75453c7003eb4b82 Gerrit-Change-Number: 18798 Gerrit-PatchSet: 3 Gerrit-Owner: Omid Shahidi <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Omid Shahidi <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 05 Aug 2022 23:51:29 +0000 Gerrit-HasComments: Yes
