Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 )
Change subject: IMPALA-6684: Fix untracked memory in KRPC ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/18798/7/be/src/runtime/row-batch.inline.h File be/src/runtime/row-batch.inline.h: http://gerrit.cloudera.org:8080/#/c/18798/7/be/src/runtime/row-batch.inline.h@22 PS7, Line 22: extra line http://gerrit.cloudera.org:8080/#/c/18798/7/be/src/runtime/row-batch.inline.h@34 PS7, Line 34: for_compression These three lines check for_compression, you can change code as: if (for_compression) { ... } else { ... } http://gerrit.cloudera.org:8080/#/c/18798/7/testdata/workloads/tpch/queries/datastream-sender.test File testdata/workloads/tpch/queries/datastream-sender.test: http://gerrit.cloudera.org:8080/#/c/18798/7/testdata/workloads/tpch/queries/datastream-sender.test@1 PS7, Line 1: ==== This file should be put in testdata/workloads/functional-query/queries http://gerrit.cloudera.org:8080/#/c/18798/7/testdata/workloads/tpch/queries/datastream-sender.test@49 PS7, Line 49: extra space -- To view, visit http://gerrit.cloudera.org:8080/18798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba2b907ce4f275a7a1fb8cf75453c7003eb4b82 Gerrit-Change-Number: 18798 Gerrit-PatchSet: 7 Gerrit-Owner: Omid Shahidi <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Omid Shahidi <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 17 Aug 2022 06:37:46 +0000 Gerrit-HasComments: Yes
