Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18828 )
Change subject: IMPALA-11469: (Addendum) Lazy initialize tmp dir list for tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18828/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/18828/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@873 PS1, Line 873: TMP_DIR_PREFIX_LIST.add(prefix); This is not thread-safe. FileSystemUtil is used in multiple threads concurrently. We could have a corrupt list here. E.g. at the middle of the for-loop, another thread initializes 'TMP_DIR_PREFIX_LIST' to a new empty list. I tend to inititialize BackendConfig in the tests to reduce the complexity here. Or we can inititialize BackendConfig in the current static clause. -- To view, visit http://gerrit.cloudera.org:8080/18828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I802fcbf70808f2127197f720a7247c3d85389d6f Gerrit-Change-Number: 18828 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 10 Aug 2022 00:26:40 +0000 Gerrit-HasComments: Yes
