Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18828 )
Change subject: IMPALA-11469: (Addendum) Initialize BackendConfig for tests ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18828/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/18828/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@858 PS2, Line 858: if (BackendConfig.INSTANCE == null) { This seems hacky. We should switch to all frontend tests to extend FrontendTestBase, and use that to initialize BackendConfig. http://gerrit.cloudera.org:8080/#/c/18828/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@866 PS2, Line 866: String s = BackendConfig.INSTANCE.getIgnoredDirPrefixList(); This could be refactored to remove the static block by moving list construction to BackendConfig and providing an accessor there. I'm not sure if that brings any performance implications. -- To view, visit http://gerrit.cloudera.org:8080/18828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I802fcbf70808f2127197f720a7247c3d85389d6f Gerrit-Change-Number: 18828 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 10 Aug 2022 17:12:56 +0000 Gerrit-HasComments: Yes
