Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18841 )

Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py
File tests/custom_cluster/test_scheduler_locality.py:

http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@26
PS1, Line 26: def get_external_ip():
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@32
PS1, Line 32: LOCAL_ASSIGNMENTS_METRIC = 
"simple-scheduler.local-assignments.total"
flake8: E305 expected 2 blank lines after class or function definition, found 1


http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@44
PS1, Line 44: i
flake8: E126 continuation line over-indented for hanging indent


http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@51
PS1, Line 51: T
flake8: E126 continuation line over-indented for hanging indent


http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@55
PS1, Line 55: i
flake8: E126 continuation line over-indented for hanging indent


http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@55
PS1, Line 55: +
flake8: E226 missing whitespace around arithmetic operator



--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:09:30 +0000
Gerrit-HasComments: Yes

Reply via email to