Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18841/2/tests/custom_cluster/test_scheduler_locality.py File tests/custom_cluster/test_scheduler_locality.py: http://gerrit.cloudera.org:8080/#/c/18841/2/tests/custom_cluster/test_scheduler_locality.py@27 PS2, Line 27: def get_external_ip(): This makes sense to move into the class definition. -- To view, visit http://gerrit.cloudera.org:8080/18841 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d Gerrit-Change-Number: 18841 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 15 Aug 2022 22:46:12 +0000 Gerrit-HasComments: Yes
