Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 )
Change subject: IMPALA-6684: Fix untracked memory in KRPC ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/18798/6/be/src/benchmarks/row-batch-serialize-benchmark.cc File be/src/benchmarks/row-batch-serialize-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/18798/6/be/src/benchmarks/row-batch-serialize-benchmark.cc@138 PS6, Line 138: uint8_t* input = const_cast<uint8_t*>( const_cast shouldn't be needed here http://gerrit.cloudera.org:8080/#/c/18798/6/be/src/benchmarks/row-batch-serialize-benchmark.cc@140 PS6, Line 140: uint8_t* compressed_output = const_cast<uint8_t*>( const_cast shouldn't be needed here http://gerrit.cloudera.org:8080/#/c/18798/6/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/18798/6/be/src/runtime/krpc-data-stream-sender.h@30 PS6, Line 30: #include "exec/data-sink.h" Move this back where it was before http://gerrit.cloudera.org:8080/#/c/18798/6/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/18798/6/be/src/runtime/row-batch.h@71 PS6, Line 71: std::unique_ptr<FreePool> free_pool_; Is unique_lock actually required here? Seem the locking here is fairly simple and using unique_lock may be wasteful. -- To view, visit http://gerrit.cloudera.org:8080/18798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba2b907ce4f275a7a1fb8cf75453c7003eb4b82 Gerrit-Change-Number: 18798 Gerrit-PatchSet: 6 Gerrit-Owner: Omid Shahidi <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Omid Shahidi <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 15 Aug 2022 19:33:56 +0000 Gerrit-HasComments: Yes
