Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18837 )
Change subject: IMPALA-11429: Set table owner after creating an Iceberg table ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/18837/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18837/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3626 PS5, Line 3626: le > nit: "is" feels a bit more natural Done http://gerrit.cloudera.org:8080/#/c/18837/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3626 PS5, Line 3626: table owner : // is hardcoded to be > nit: this part was fuzzy for me, maybe something like: Done http://gerrit.cloudera.org:8080/#/c/18837/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3633 PS5, Line 3633: throw new ImpalaRuntimeException("Failed to set table owner after creating " + : "Iceberg table but the table has been created successfully", e); > With Ranger enabled and a failing alter operation this table would be inacc Well yes, if the ALTER TABLE fails then we have the same situation we are now without this patch. I don't see there is anything we can do about it but I'm open for ideas :) The ideal solution would be to provide owner param to Iceberg API and make this one step, but the API is not prepared for that ATM. http://gerrit.cloudera.org:8080/#/c/18837/5/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18837/5/tests/query_test/test_iceberg.py@130 PS5, Line 130: pytest.skip() > Wouldn't a time.sleep(5) solve the issue after create? If I added a sleep than instead of IMPALA-11509 we would bump into IMPALA-11502 that wouldn't make Impala stuck in an infinite loop but would still fail this test. -- To view, visit http://gerrit.cloudera.org:8080/18837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cac198a4a53be3599cb582864ee5f8c269202c0 Gerrit-Change-Number: 18837 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Mon, 22 Aug 2022 12:25:11 +0000 Gerrit-HasComments: Yes
