Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18837 )
Change subject: IMPALA-11429: Set table owner after creating an Iceberg table ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18837/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18837/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3633 PS5, Line 3633: throw new ImpalaRuntimeException("Failed to set table owner after creating " + : "Iceberg table but the table has been created successfully", e); > Rollback would in fact be a good choice here but I don't think I should imp I see your points, 3 operations indeed a bit too much, I am happy to go with this solution. One more question, does this exception propagated to the user? Looks like throwing an exception here would trigger another ImpalaRuntimeException instead of a "successful" operation similar to "Table already exists.". -- To view, visit http://gerrit.cloudera.org:8080/18837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cac198a4a53be3599cb582864ee5f8c269202c0 Gerrit-Change-Number: 18837 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 24 Aug 2022 11:57:43 +0000 Gerrit-HasComments: Yes
