Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 )
Change subject: IMPALA-11528: Catalogd should start up even with a corrupt Hive function. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18927/2/java/shaded-deps/hive-exec/pom.xml File java/shaded-deps/hive-exec/pom.xml: http://gerrit.cloudera.org:8080/#/c/18927/2/java/shaded-deps/hive-exec/pom.xml@103 PS2, Line 103: UDAF.class > Shouldn't we add other UDAF classes like UDAFEvaluatorResolver. The other classes are already imported from line 111. But you did get me thinking that I should make this a little safer, so I added a catch for LinkageError so that in case anything new is added, we catch it and just skip the function. http://gerrit.cloudera.org:8080/#/c/18927/2/java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java: http://gerrit.cloudera.org:8080/#/c/18927/2/java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java@25 PS2, Line 25: We import the class NumberParseException from : * Google's phone number library that won't be shaded with the UDF jar > Where do we import it? CorruptUdf seems a valid udf to me at the first glan Yeah, I was a bit too quick with the push. I missed a couple of files and I had it on my list to change this comment too. This version is going to be a valid UDF. The test is going to use this version to create the function with HMS. Then I'm going to replace the jar file containing this with a version of this class that is invalid. http://gerrit.cloudera.org:8080/#/c/18927/2/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/18927/2/tests/custom_cluster/test_permanent_udfs.py@183 PS2, Line 183: funcction > typo Done -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 18:57:49 +0000 Gerrit-HasComments: Yes
