Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 )
Change subject: IMPALA-11528: Catalogd should start up with a corrupt Hive function. ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/18927/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18927/7//COMMIT_MSG@12 PS7, Line 12: A valid Hive SQL function gets created in HMS. This UDF is written in Java and > nit: plz wrap commit message at 72 Done http://gerrit.cloudera.org:8080/#/c/18927/7//COMMIT_MSG@22 PS7, Line 22: To fix this, we need to include UDAF in the shaded jar. > This is a parallel fix for the case when the base class is Udaf, right? Actually, this is needed because of what I stated on lines 19 and 20 here. The FunctionUtils.getUDFClassType() method has a line that says "UDAF.class.isAssignable()", so it needs the UDAF object in the shaded jar regardless of whether it derives from a UDAF. I changed the message so hopefully it is more clear. http://gerrit.cloudera.org:8080/#/c/18927/7/tests/custom_cluster/test_permanent_udfs.py File tests/custom_cluster/test_permanent_udfs.py: http://gerrit.cloudera.org:8080/#/c/18927/7/tests/custom_cluster/test_permanent_udfs.py@a162 PS7, Line 162: : > Why was this removed? This test should still not work if Hive doesn't suppo No reason. This was removed as part of just general testing in my local environment while I was figuring out how to run this when it is not "exhaustive" On the final push, I"ll put this back and I'll also add this before the "def test_corrupt_java_udf" line as well. -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 31 Aug 2022 14:51:59 +0000 Gerrit-HasComments: Yes
