Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 18: (5 comments) http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG@9 PS18, Line 9: between Kudu tables. Could you list limitations of this implementations, e.g. not being able to clone a Kudu table with range partitions, etc. Any other limitations, BTW? http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG@10 PS18, Line 10: Cloing Cloning http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@173 PS18, Line 173: analyzer.ensureTableNotBucketed(srcTable); Just to clarify: does this mean that a Kudu table with hash partitions cannot be cloned either? http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3840 PS18, Line 3840: for (KuduPartitionParam kuduPartitionParam : kuduTable.getPartitionBy()) { It would be great to add a comment in the code to shed more light on what prevents cloning Kudu tables with range partitions. When reading this code, it seems a bit strange that cloning a hash-partitioned Kudu table is possible, but cloning a range-partitioned Kudu table is not. http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2448 PS18, Line 2448: Does it make sense to add more AnalysisError() to reflect on other restrictions: * Kudu tables with range partitions cannot be cloned * Kudu tables with hash partitions cannot be cloned (is that true, BTW?)? That's just to be explicit what to expect when a request to clone such Kudu table arrives. -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 18 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Comment-Date: Thu, 08 Sep 2022 23:03:39 +0000 Gerrit-HasComments: Yes
