Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 20: (5 comments) http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG@9 PS18, Line 9: between Kudu tables, > Could you list limitations of this implementations, e.g. not being able to It is not supported to clone a Kudu table with range paritions. No other limitations. http://gerrit.cloudera.org:8080/#/c/18729/18//COMMIT_MSG@10 PS18, Line 10: limita > Cloning Done http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@173 PS18, Line 173: analyzer.ensureTableNotBucketed(srcTable); > Just to clarify: does this mean that a Kudu table with hash partitions cann Hive create bucketed table and specified 'CLUSTERED BY (column_a) INTO n BUCKETS', for example: CREATE TABLE `user_info_bucketed`( `user_id` bigint, `firstname` string, `lastname` string) COMMENT 'A bucketed copy of user_info' PARTITIONED BY ( `ds` string) CLUSTERED BY ( user_id) INTO 16 BUCKETS The table `user_info_bucketed` has 16 buckets. When impala access `user_info_bucketed` and execute following query: create table `user_cloned` like `user_info_bucketed`. The function ensureTableNotBucketed(srcTable) will throw AnalysisException: default.user_info_bucketed is a bucketed table. When a kudu table with hash partitions, The bucket is 0. It can be cloned. http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3840 PS18, Line 3840: if (tbl.getParameters().containsKey(IcebergTable.ICEBERG_CATALOG)) { > It would be great to add a comment in the code to shed more light on what p I added the comment. When getting range partitions List<String> by kudu client, there is no elegant way to convert List<String> to fe/src/main/java/org/apache/impala/analysis/RangePartition.java http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/18729/18/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2448 PS18, Line 2448: // Kudu tables with range partitions cannot be cloned > Does it make sense to add more AnalysisError() to reflect on other restrict Done -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 20 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Comment-Date: Tue, 27 Sep 2022 06:27:45 +0000 Gerrit-HasComments: Yes
