Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18962 )
Change subject: IMPALA-11511: Add build options for reducing binary sizes ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18962/1/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: http://gerrit.cloudera.org:8080/#/c/18962/1/bin/dump_breakpad_symbols.py@297 PS1, Line 297: args = [dump_syms, decompressed_binary] : if objcopy_retcode != 0: Should we check objcopy_retcode before calling dump_syms -- To view, visit http://gerrit.cloudera.org:8080/18962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04a20258a86053d8f3972b9c7c81cd5bec1bbb66 Gerrit-Change-Number: 18962 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 13 Sep 2022 00:54:45 +0000 Gerrit-HasComments: Yes
