Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18962 )
Change subject: IMPALA-11511: Add build options for reducing binary sizes ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18962/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18962/1//COMMIT_MSG@9 PS1, Line 9: Impala's build produces has dozens of C++ binaries "produces has" doesn't read right. http://gerrit.cloudera.org:8080/#/c/18962/1/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/18962/1/be/CMakeLists.txt@220 PS1, Line 220: SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g1") Will this end up adding it in Release mode? Is the next line sufficient? -- To view, visit http://gerrit.cloudera.org:8080/18962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04a20258a86053d8f3972b9c7c81cd5bec1bbb66 Gerrit-Change-Number: 18962 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 13 Sep 2022 17:03:47 +0000 Gerrit-HasComments: Yes
