Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 )
Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table ...................................................................... Patch Set 4: (2 comments) > Patch Set 2: > > (2 comments) http://gerrit.cloudera.org:8080/#/c/18812/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18812/2/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@519 PS2, Line 519: if (!oldColumns.contains(column.getColumnName())) { > should we raise an error when oldColumns.contains(column.getColumnName()) a Hi jian, impala already have check here: https://github.com/apache/impala/blob/4.1.0/fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java#L84. http://gerrit.cloudera.org:8080/#/c/18812/2/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test: http://gerrit.cloudera.org:8080/#/c/18812/2/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test@352 PS2, Line 352: ---- CATCH > could you add another test without the `if not exists` clause: Done -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Tue, 13 Sep 2022 06:40:40 +0000 Gerrit-HasComments: Yes
