Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18812 )
Change subject: IMPALA-11463: Support IF NOT EXISTS in alter table add columns for kudu table ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/18812/4/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18812/4/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@519 PS4, Line 519: if (!oldColumns.contains(column.getColumnName())) { : alterTableOptions.addColumn(createColumnSchema(column, false)); : } Should we skip the existing column if "if not exists" is not specified in the query? I don't see how "if not exists" is checked in the alter table statement. http://gerrit.cloudera.org:8080/#/c/18812/4/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test: http://gerrit.cloudera.org:8080/#/c/18812/4/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test@365 PS4, Line 365: alter table tbl_to_alter add if not exists columns (new_col4 string, new_col5 int) The data type of existing new_col4 is INT. Add one more test case for existing column with same data type. http://gerrit.cloudera.org:8080/#/c/18812/4/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test@369 PS4, Line 369: string Type of new_col5 is int. Why return string? -- To view, visit http://gerrit.cloudera.org:8080/18812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If624b3bd12eeb1a848e9fc4b6099c47bcf80c9f6 Gerrit-Change-Number: 18812 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Thu, 15 Sep 2022 09:53:52 +0000 Gerrit-HasComments: Yes
