Csaba Ringhofer has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/18927 )

Change subject: IMPALA-11528: Catalogd should start up with a corrupt Hive 
function.
......................................................................

IMPALA-11528: Catalogd should start up with a corrupt Hive function.

This commit handles the case for a specific kind of corrupt function
within the Hive Metastore in the following situation:

A valid Hive SQL function gets created in HMS. This UDF is written in
Java and must derive from the "UDF" class. After creating this function
in Impala, we then replace the underlying jar file with a class that
does NOT derive from the "UDF" class.

In this scenario, catalogd should reject the function and still start
up gracefully. Before this commit, catalogd wasn't coming up. The
reason for this was because the Hive function
FunctionUtils.getUDFClassType() has a dependency on UDAF and was
throwing a LinkageError exception, so we need to include the UDAF
class in the shaded jar.

Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112
Reviewed-on: http://gerrit.cloudera.org:8080/18927
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Tamas Mate <[email protected]>
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
A java/test-corrupt-hive-udfs/pom.xml
A java/test-corrupt-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java
A java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java
M testdata/bin/copy-udfs-udas.sh
M tests/custom_cluster/test_permanent_udfs.py
8 files changed, 153 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Tamas Mate: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/18927
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112
Gerrit-Change-Number: 18927
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Tamas Mate <[email protected]>

Reply via email to