Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18927 )
Change subject: IMPALA-11528: Catalogd should start up with a corrupt Hive function. ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/18927/9/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/18927/9/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1767 PS9, Line 1767: } catch (Exception e) { : LOG.error("Skipping function load: " + function.getFunctionName(), e); : } catch (LinkageError e) { : LOG.error("Skipping function load: " + function.getFunctionName(), e); nit: could be multi catch parameter: } catch (Exception | LinkageError e) { LOG.error("Skipping function load: " + function.getFunctionName(), e); http://gerrit.cloudera.org:8080/#/c/18927/2/java/shaded-deps/hive-exec/pom.xml File java/shaded-deps/hive-exec/pom.xml: http://gerrit.cloudera.org:8080/#/c/18927/2/java/shaded-deps/hive-exec/pom.xml@103 PS2, Line 103: UDAF.class > The other classes are already imported from line 111. I think UDAFEvaluatorResolver won't be included, line 111 points to 'ql/udf' but UDAFEvaluatorResolver is under 'ql/exec' package. http://gerrit.cloudera.org:8080/#/c/18927/9/java/test-corrupt-hive-udfs/pom.xml File java/test-corrupt-hive-udfs/pom.xml: http://gerrit.cloudera.org:8080/#/c/18927/9/java/test-corrupt-hive-udfs/pom.xml@1 PS9, Line 1: <!-- nit: <?xml version="1.0" encoding="UTF-8"?> -- To view, visit http://gerrit.cloudera.org:8080/18927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 07 Sep 2022 08:34:15 +0000 Gerrit-HasComments: Yes
