Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )
Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/18940/10/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java File fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java: http://gerrit.cloudera.org:8080/#/c/18940/10/fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java@78 PS10, Line 78: protected List<ColumnDef> finalColDefs_; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/18940/10/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: http://gerrit.cloudera.org:8080/#/c/18940/10/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@546 PS10, Line 546: "functional", "ALTER VIEW functional.alltypes_view UNSET TBLPROPERTIES ('a', 'c')"); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18 Gerrit-Change-Number: 18940 Gerrit-PatchSet: 10 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 26 Sep 2022 16:29:26 +0000 Gerrit-HasComments: Yes
