Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )
Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES ...................................................................... Patch Set 11: Thanks for updating the patch quickly! Sorry that I still have one more comment. I just realized that we are lack of end to end tests to make sure the DDL is executed correctly throught HMS. Currently we just have FE unit tests. Could you add some end-to-end tests, e.g. in testdata/workloads/functional-query/queries/QueryTest/views-ddl.test ? It's invoked here: https://github.com/apache/impala/blob/10c19b1a5730a898e17cc653be6bd19f0dc3340e/tests/metadata/test_ddl.py#L522 There are some similar tests in test_ddl.py that probably we can reuse, e.g. test_views_describe, test_alter_table, etc. I think basically we just need tests to run Create/Alter View with Set/UnSet tblproperties and then use DESCRIBE FORMATTED to verify the tblproperties. You can use the following command to run a single e2e test: impala-py.test tests/metadata/test_ddl.py::TestDdlStatements::test_views_ddl ref: https://cwiki.apache.org/confluence/display/IMPALA/How+to+load%2C+run%2C+and+create+new+Impala+tests#Howtoload,run,andcreatenewImpalatests-Runmostend-to-endtests(butnotcustomclustertests) -- To view, visit http://gerrit.cloudera.org:8080/18940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18 Gerrit-Change-Number: 18940 Gerrit-PatchSet: 11 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 27 Sep 2022 00:58:14 +0000 Gerrit-HasComments: No
