Qifan Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19033 )

Change subject: [WIP] IMPALA-11604 Planner changes for CPU usage
......................................................................


Patch Set 8:

(2 comments)

Rework and improved the calculation for AggregationNode.

http://gerrit.cloudera.org:8080/#/c/19033/7/common/thrift/Frontend.thrift
File common/thrift/Frontend.thrift:

http://gerrit.cloudera.org:8080/#/c/19033/7/common/thrift/Frontend.thrift@747
PS7, Line 747: The memory limit variable provides the per host estimated-memory 
limit.
             :   4: optional
> Add the more detailed description for measuring this variable
Done


http://gerrit.cloudera.org:8080/#/c/19033/7/common/thrift/Query.thrift
File common/thrift/Query.thrift:

http://gerrit.cloudera.org:8080/#/c/19033/7/common/thrift/Query.thrift@872
PS7, Line 872: stimated total data processed per instan
> Traditionally CPU usage is measured in time. Here we use computing/processi
Yeah. The use cpu usage is a kind of implicit. Changed the name to data 
processed throughout the patch.



--
To view, visit http://gerrit.cloudera.org:8080/19033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If32dc770dfffcdd0be2b5555a789a7720952c68a
Gerrit-Change-Number: 19033
Gerrit-PatchSet: 8
Gerrit-Owner: Qifan Chen <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Tue, 27 Sep 2022 19:16:07 +0000
Gerrit-HasComments: Yes

Reply via email to