Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 )
Change subject: IMPALA-11604 Planner changes for CPU usage ...................................................................... Patch Set 11: (6 comments) http://gerrit.cloudera.org:8080/#/c/19033/10/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/19033/10/common/thrift/Frontend.thrift@752 PS10, Line 752: 5: optional i64 max_processing_cost_limit > It's probably best to stick with vcores here as what the executor group pro This thrift structure defines an executor group set for internal use. Using processing code limit here is better since it hides the details of translating #vcores to processing cost. http://gerrit.cloudera.org:8080/#/c/19033/10/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/19033/10/common/thrift/Query.thrift@873 PS10, Line 873: 12: optional i64 dedicated_coord_mem_estimate; > Vcores here also. This thrift structure contains the relevant info for a query. Using processing code limit here is better since it hides the details of translating #vcores to processing cost. http://gerrit.cloudera.org:8080/#/c/19033/10/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/19033/10/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@627 PS10, Line 627: .setProcessingCost( > Use (abstract) processingCost naming instead of processedBytes. Done http://gerrit.cloudera.org:8080/#/c/19033/10/fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java File fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java: http://gerrit.cloudera.org:8080/#/c/19033/10/fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java@362 PS10, Line 362: public long computeProcessingCost() { > rename all of these to computeProcessingCost or similar Done http://gerrit.cloudera.org:8080/#/c/19033/10/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java File fe/src/main/java/org/apache/impala/planner/HashJoinNode.java: http://gerrit.cloudera.org:8080/#/c/19033/10/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@308 PS10, Line 308: float eqJoinPredicateEvalCost = > eqJoinPredicateEvalCost Done http://gerrit.cloudera.org:8080/#/c/19033/10/fe/src/main/java/org/apache/impala/util/ExprUtil.java File fe/src/main/java/org/apache/impala/util/ExprUtil.java: http://gerrit.cloudera.org:8080/#/c/19033/10/fe/src/main/java/org/apache/impala/util/ExprUtil.java@109 PS10, Line 109: public static float computeExprsTotalCost(List<? extends Expr> exprs) { > Use List<? extends Expr> to share the same function. Done -- To view, visit http://gerrit.cloudera.org:8080/19033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32dc770dfffcdd0be2b5555a789a7720952c68a Gerrit-Change-Number: 19033 Gerrit-PatchSet: 11 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 30 Sep 2022 14:22:36 +0000 Gerrit-HasComments: Yes
