Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19042 )
Change subject: IMPALA-11235: Support Pluggable Authentication for Impala ...................................................................... Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c/19042/2/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/19042/2/be/src/rpc/authentication.cc@334 PS2, Line 334: // Wrapper around the function we use to check passwords with plugin which has the line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/be/src/transport/THttpServer.h File be/src/transport/THttpServer.h: http://gerrit.cloudera.org:8080/#/c/19042/2/be/src/transport/THttpServer.h@76 PS2, Line 76: // if authentication is successful. Must be set if 'has_ldap_' or 'has_plugin_' line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/be/src/transport/THttpServer.h@239 PS2, Line 239: bool check_trusted_domain, bool check_trusted_auth_header, bool has_saml, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/be/src/transport/THttpServer.h@245 PS2, Line 245: return std::shared_ptr<TTransport>(new THttpServer(trans, has_ldap_, has_plugin_, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/be/src/transport/THttpServer.h@246 PS2, Line 246: has_kerberos_, has_saml_, use_cookies_, check_trusted_domain_, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/fe/src/test/java/org/apache/impala/customcluster/PluginImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/PluginImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/19042/2/fe/src/test/java/org/apache/impala/customcluster/PluginImpalaShellTest.java@36 PS2, Line 36: * Impala shell connectivity tests for PLUGIN authentication. This class contains line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/fe/src/test/java/org/apache/impala/customcluster/PluginImpalaShellTest.java@37 PS2, Line 37: * the common test and methods that are used to test Simple bind and Search bind line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/fe/src/test/java/org/apache/impala/customcluster/PluginJdbcTest.java File fe/src/test/java/org/apache/impala/customcluster/PluginJdbcTest.java: http://gerrit.cloudera.org:8080/#/c/19042/2/fe/src/test/java/org/apache/impala/customcluster/PluginJdbcTest.java@56 PS2, Line 56: ImpalaJdbcClient.getLdapConnectionStr(connectionType_, TEST_USER_1, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/19042/2/shell/impala_shell.py@2128 PS2, Line 2128: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/shell/impala_shell.py@2128 PS2, Line 2128: p = subprocess.Popen(shlex.split(options.plugin_password_cmd), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/19042/2/tests/shell/test_shell_commandline.py@733 PS2, Line 733: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/tests/shell/test_shell_commandline.py@733 PS2, Line 733: result_1 = run_impala_shell_cmd(vector, ['--plugin', line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/tests/shell/test_shell_commandline.py@734 PS2, Line 734: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/tests/shell/test_shell_commandline.py@734 PS2, Line 734: '--plugin_password_cmd=cmddoesntexist'], line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/tests/shell/test_shell_commandline.py@743 PS2, Line 743: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/19042/2/tests/shell/test_shell_commandline.py@743 PS2, Line 743: result_2 = run_impala_shell_cmd(vector, ['--plugin', line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/19042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaaef6bffe641ece30e7fc3756688ef30722dfe1 Gerrit-Change-Number: 19042 Gerrit-PatchSet: 2 Gerrit-Owner: Minghui Zhu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 28 Sep 2022 06:33:50 +0000 Gerrit-HasComments: Yes
