Minghui Zhu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19042 )
Change subject: IMPALA-11235: Support Pluggable Authentication for Impala ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19042/1/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/19042/1/be/src/rpc/authentication.cc@313 PS1, Line 313: LOG(INFO) << "user: " << user << "pass: " << pass; > better not to log password for security reasons. log for debug, forget to delete it. I will check others. -- To view, visit http://gerrit.cloudera.org:8080/19042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaaef6bffe641ece30e7fc3756688ef30722dfe1 Gerrit-Change-Number: 19042 Gerrit-PatchSet: 3 Gerrit-Owner: Minghui Zhu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Minghui Zhu <[email protected]> Gerrit-Comment-Date: Wed, 28 Sep 2022 06:46:49 +0000 Gerrit-HasComments: Yes
