Minghui Zhu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19023 )
Change subject: IMPALA-11566: Provide SQL parsing capabilities to other applications in the form of jar packages ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19023/2/fe/src/main/java/org/apache/impala/util/FunctionCallExprVisitor.java File fe/src/main/java/org/apache/impala/util/FunctionCallExprVisitor.java: http://gerrit.cloudera.org:8080/#/c/19023/2/fe/src/main/java/org/apache/impala/util/FunctionCallExprVisitor.java@34 PS2, Line 34: public class FunctionCallExprVisitor implements StmtVisitor<StmtNode> { > when will the FunctionCallExprVisitor be used? in the other project outside impala where we use parser to find all functions in the sql, would write like this: StatementBase node = Parser.parse(sql); FunctionCallExprVisitor functionCallExprVisitor = new FunctionCallExprVisitor(); node.accept(functionCallExprVisitor); List<FunctionCallExpr> funcCalls = functionCallExprVisitor.getFuncCalls(); -- To view, visit http://gerrit.cloudera.org:8080/19023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I246b088310f25b809d9e598c0ecc6613d9749ee3 Gerrit-Change-Number: 19023 Gerrit-PatchSet: 2 Gerrit-Owner: Minghui Zhu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Minghui Zhu <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 28 Sep 2022 06:33:55 +0000 Gerrit-HasComments: Yes
